overlay: store if there are no ACLs in the layer #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
reviewed
Jul 6, 2023
giuseppe
force-pushed
the
support-erofs-noacl
branch
from
e43be14
to
39f162f
Compare
|
None of this seems needed. We already store the LCFS_EROFS_FLAGS_HAS_ACL in the struct lcfs_erofs_header_s at offset 0 in the image. |
Right, I raised the same point in this thread #1663 (comment) but basically we're not using |
giuseppe
force-pushed
the
support-erofs-noacl
branch
from
39f162f
to
9164ae0
Compare
giuseppe
force-pushed
the
support-erofs-noacl
branch
from
9164ae0
to
a308b84
Compare
|
fixed the patch to read the flag from the composefs file itself, it is much simpler now |
alexlarsson
reviewed
Jul 6, 2023
alexlarsson
reviewed
Jul 6, 2023
giuseppe
force-pushed
the
support-erofs-noacl
branch
2 times, most recently
from
858cd50
to
1657126
Compare
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
support-erofs-noacl
branch
from
1657126
to
c7ce29b
Compare
if there are no ACLs, then we mount the EROFS layer with the "noacl" mount option. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
support-erofs-noacl
branch
from
c7ce29b
to
0d28d3e
Compare
alexlarsson
approved these changes
Jul 6, 2023
|
@rhatdan fine to merge this as well? |
|
LGTM |
mtrmac
reviewed
Sep 6, 2023
| erofsBlob := d.getErofsBlob(lowerID) | ||
| _, err = os.Stat(erofsBlob) | ||
| maybeAddComposefsMount := func(lowerID string, i int) (string, error) { | ||
| composefsBlob := d.getComposefsData(lowerID) |
There was a problem hiding this comment.
s/composefsBlob/composefsDataDir/g?
| if err != nil { | ||
| if os.IsNotExist(err) { | ||
| return "", nil | ||
| } | ||
| return "", err | ||
| } | ||
| logrus.Debugf("overlay: using erofs blob %s for lower %s", erofsBlob, lowerID) | ||
| logrus.Debugf("overlay: using composefs blob %s for lower %s", composefsBlob, lowerID) |
There was a problem hiding this comment.
… and something like s/blob/subdirectory/ here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if there are no ACLs, then we mount the EROFS layer with the "noacl" mount option.
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com